Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ServerWebExchange as Hint property #2977

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Added ServerWebExchange as Hint property #2977

merged 3 commits into from
Oct 10, 2023

Conversation

usrivastava92
Copy link
Contributor

📜 Description

Added ServerWebExchange as a property in the Hint object

💡 Motivation and Context

Closes #2974

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@usrivastava92 usrivastava92 mentioned this pull request Oct 10, 2023
Closed
@adinauer
Copy link
Member

Thanks for the PR, will run formatting and API generation on it.

adinauer
adinauer approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...ing/jakarta/webflux/SentryWebExceptionHandler.java 92.59% <100.00%> (+0.28%) ⬆️
...ntry/spring/webflux/SentryWebExceptionHandler.java 94.44% <100.00%> (+0.32%) ⬆️
sentry/src/main/java/io/sentry/TypeCheckHint.java 0.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@adinauer adinauer merged commit 86f0de8 into getsentry:main Oct 10, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ServerWebExchange as hint in SentryWebExceptionHandler
2 participants
@usrivastava92 @adinauer